Skip to content

feat(regenerate): updates for regular release 4 #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2019
Merged

feat(regenerate): updates for regular release 4 #583

merged 2 commits into from
Jul 25, 2019

Conversation

mamoonraja
Copy link
Member

@mamoonraja mamoonraja commented Jul 24, 2019 •
edited
Loading

Release 4 - 2019

Includes

  • Assistant Search Skill support
  • Compare and Comply basicauth constructor
  • Compare and Comply model changes
  • NLU Confidence field in EntitesResult and EntityMention
  • STT AcousticModel & LanguageModel have Updated field
  • Compare Comply contract_type --> contract_types. contract_type was never returned by the service so not a breaking change.
  • Ensure STT TrainLanguageModel and TrainAcousticModel return void/empty object and not TrainingResponse (service only returns TrainingResponse if we set strict to false)
  • Integration tests

@mamoonraja mamoonraja requested a review from mediumTaj July 24, 2019 20:42
mediumTaj
mediumTaj suggested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey mamoon, a couple of changes here

@mamoonraja
feat(regenerate): updates for regular release 4
10c4529 
Includes changes to: STT, C&C, AssistantV2 and NLU
mediumTaj
mediumTaj approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@mamoonraja mamoonraja merged commit ea6fe3a into master Jul 25, 2019
@mamoonraja mamoonraja deleted the release-4-2019 branch August 14, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mediumTaj mediumTaj mediumTaj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamoonraja @mediumTaj