Skip to content

Feat/dynamic model #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Feat/dynamic model #594

merged 4 commits into from
Sep 18, 2019

Conversation

mamoonraja
Copy link
Member

The core was updated to add dynamic models, this pr regenerate SDK and uses dynamic models class for additional properties.

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, just one question

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good! Be sure to revise the generator so MessageContextSkills inherits from DynamicModel<MessageContextSkill>

@mamoonraja mamoonraja merged commit ad05c24 into 4.0.0-rc2 Sep 18, 2019
@mamoonraja mamoonraja mentioned this pull request Oct 3, 2019
@mediumTaj
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants