-
Notifications
You must be signed in to change notification settings - Fork 207
5.0.0.rc #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0.0.rc #662
Conversation
…skill system BREAKING CHANGE: MessageContextSkill
BREAKING CHANGE: Moved from VoiceModel and VoiceModels to CustomModel and CustomModels
…d endtimes to DateTime BREAKING CHANGE: change startTime and encTime to DateTime for GetTrainingUsave for VisualRecognitionV4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall mamoon, just a couple of comments. Also I don't see personality insights deprecation in this pr, has it been added already?
@@ -1,5 +1,5 @@ | |||
/** | |||
* (C) Copyright IBM Corp. 2018, 2020. | |||
* (C) Copyright IBM Corp. 2019, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange that these are being changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how this is happening. Looking into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strangely the command in lint-copyrights gives 2019
git log --pretty=format:"%ad" --follow -M95% --date=format:%Y Scripts/Services/Assistant/V1/AssistantService.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it is correct: https://github.com/watson-developer-cloud/unity-sdk/commits/52f0cf940865fc28cbe14833c69bed8293149a1a/Scripts/Services/Assistant/V1/Model/DialogNode.cs
The directory structure got refactored in 2019: https://github.com/watson-developer-cloud/unity-sdk/tree/v2.13.2 in 2.14.0
/// <summary> | ||
/// Constant SUGGESTION for suggestion | ||
/// </summary> | ||
public const string SUGGESTION = "suggestion"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these being replaced somewhere else? or maybe not needed as its a response?
Scripts/Services/VisualRecognition/V4/VisualRecognitionService.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to merge in #663 first and update tests
feat(regeneration): regenerated with generator 3.21.0 and api def sdk-major-release-2020
…dk into 5.0.0.rc1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks much better!
@@ -50,6 +50,8 @@ public class DiscoveryV2IntegrationTests | |||
public void OneTimeSetup() | |||
{ | |||
LogSystem.InstallDefaultReactors(); | |||
analyzeDocumentFile = Application.dataPath + "/Watson/Tests/TestData/DiscoveryV1/exampleConfigurationData.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these running? I think we can exclude disco v2 tests as we don't have a persistent instance
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.