Skip to content

5.0.0.rc #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 10, 2020
Merged

5.0.0.rc #662

merged 19 commits into from
Dec 10, 2020

Conversation

mamoonraja
Copy link
Member

No description provided.

@mamoonraja mamoonraja requested a review from mediumTaj December 9, 2020 00:16
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall mamoon, just a couple of comments. Also I don't see personality insights deprecation in this pr, has it been added already?

@@ -1,5 +1,5 @@
/**
* (C) Copyright IBM Corp. 2018, 2020.
* (C) Copyright IBM Corp. 2019, 2020.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange that these are being changed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how this is happening. Looking into it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strangely the command in lint-copyrights gives 2019

git log --pretty=format:"%ad" --follow -M95% --date=format:%Y Scripts/Services/Assistant/V1/AssistantService.cs

Copy link
Member Author

@mamoonraja mamoonraja Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// <summary>
/// Constant SUGGESTION for suggestion
/// </summary>
public const string SUGGESTION = "suggestion";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these being replaced somewhere else? or maybe not needed as its a response?

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge in #663 first and update tests

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks much better!

@@ -50,6 +50,8 @@ public class DiscoveryV2IntegrationTests
public void OneTimeSetup()
{
LogSystem.InstallDefaultReactors();
analyzeDocumentFile = Application.dataPath + "/Watson/Tests/TestData/DiscoveryV1/exampleConfigurationData.json";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these running? I think we can exclude disco v2 tests as we don't have a persistent instance

@mamoonraja mamoonraja merged commit 138c355 into master Dec 10, 2020
@mediumTaj
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants