Skip to content

chore: not use recursive omit #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore: not use recursive omit #173

merged 1 commit into from
Sep 4, 2024

Conversation

Timeless0911
Copy link
Contributor

Summary

omitDeep will break some element like

tools: {
  rspack: {
    plugins: [
      new rspack.BannerPlugin({
        banner: 'hello world',
        footer: true,
        stage: 10000,
      }),
    ],
  },
},

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 enabled auto-merge (squash) September 4, 2024 12:12
fi3ework
fi3ework approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope we won't need this TS snippet again one day. :P

@Timeless0911 Timeless0911 merged commit ccd5299 into main Sep 4, 2024
7 checks passed
@Timeless0911 Timeless0911 deleted the chore/use-omit branch September 4, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fi3ework fi3ework fi3ework approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Timeless0911 @fi3ework