-
Notifications
You must be signed in to change notification settings - Fork 46
feat: support css in bundless mode #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
238dfd3
to
641a374
Compare
068ae3c
to
f54b6ff
Compare
CodSpeed Performance ReportMerging #206 will not alter performanceComparing Summary
Benchmarks breakdown
|
css tests like less should be added more |
Add some tests about
And has the redirect.css behaviour been tested? |
By the way, it's better to add the document alongside. @Timeless0911 What about adding the basic doc outline today? |
I'll make a draft later today. |
we should remember to add banner and footer tests about bundleless css. |
the files are in the Maybe we can support it by adjusting bannerPlugin in the future, this is a TODO |
Open an issue and we can track it in the future. |
Generally LGTM, some bug has been tracked, we could fix afterwards. cc @Timeless0911 |
TODO:
|
Summary
closes #182
cssConfig.ts
andcomposeCssConfig
CssExtractPlugin.loader
withLibCssExtractLoader
which is forkedCssExtractPlugin
RemoveCssExtractAssetPlugin
redirect.style
Related Links
Checklist