feat: support import.meta.url shim for CJS
#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib canceled.
|
fi3ework
force-pushed
the
shim-importmetaurl
branch
from
8f3ab58 to
0eaf6a8
Compare
fi3ework
force-pushed
the
shim-importmetaurl
branch
from
0eaf6a8 to
2f6be01
Compare
Timeless0911
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Rsbuild plugin will shim
import.meta.urlfor CommonJS modules.import.meta.urlwithimportMetaUrl.importMetaUrlto the end of the module (can't inject at the beginning because of"use strict";).This is a short-term solution, and we hope to provide built-in polyfills like
node.__filenameon Rspack side.Related Links
Checklist