Skip to content

fix: use ESM chunkLoading for "esm" format #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Oct 8, 2024

Summary

Fix #254.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit be7062c
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/6704da3f57222500081704c0
😎 Deploy Preview https://deploy-preview-256--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #256 will not alter performance

Comparing async-chunk (e5a266d) with main (d1be3a7)

Summary

✅ 2 untouched benchmarks

@Timeless0911
Copy link
Contributor

What if the target is web instead of node?

@fi3ework
Copy link
Member Author

fi3ework commented Oct 8, 2024

@Timeless0911 Same, but I don't think this will work for typical web scenes. Due to webpack/webpack#15697, the dynamic chunk can't be bundled it can't be statically resolved. It has been tracked in #45.

@Timeless0911 Timeless0911 merged commit 5e5b639 into main Oct 8, 2024
11 checks passed
@Timeless0911 Timeless0911 deleted the async-chunk branch October 8, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: require call appears in ESM output when there’s a dynamic import.
2 participants