Skip to content

fix: pass in projectReferences to avoid missing some error reports #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Timeless0911
Copy link
Contributor

Summary

fix: #283

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #288 will not alter performance

Comparing fix/reference (7e4358a) with main (e67e8c6)

Summary

✅ 3 untouched benchmarks

@fi3ework
Copy link
Member

Do we need to add rest fields alongside, are they useful?

image

@Timeless0911
Copy link
Contributor Author

Do we need to add rest fields alongside, are they useful?

image

According to Typescript source code, it seems they are not useful yet.

interface CreateProgramOptions {
    rootNames: readonly string[];
    options: CompilerOptions;
    projectReferences?: readonly ProjectReference[];
    host?: CompilerHost;
    oldProgram?: Program;
    configFileParsingDiagnostics?: readonly Diagnostic[];
}

@fi3ework fi3ework merged commit 1ca47fd into main Oct 14, 2024
19 checks passed
@fi3ework fi3ework deleted the fix/reference branch October 14, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Rslib failed to report the type errors
2 participants