Skip to content

feat(create-rslib): setup Node.js package templates #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Oct 22, 2024

Summary

Setup Node.js package templates for create-rslib:

Template Description
node-dual-js Node.js dual ESM/CJS package
node-dual-ts Node.js dual ESM/CJS package written in TypeScript
node-esm-js Node.js pure ESM package
node-esm-ts Node.js pure ESM package written in TypeScript

I didn't add pure CJS templates because it is not recommended.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 438a2eb
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67177534bd425f00081e8be8
😎 Deploy Preview https://deploy-preview-319--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework
Copy link
Member

fi3ework commented Oct 22, 2024

FYI: I'm working on react boilerplate. Let's not repeatedly do the same thing in the future. 🤣

Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #319 will not alter performance

Comparing create_rslib_1022 (765fb41) with main (c8ae3a7)

Summary

✅ 5 untouched benchmarks

@chenjiahan
Copy link
Member Author

Haha, fortunately we didn’t make the same template.

@Timeless0911 Timeless0911 merged commit 0205864 into main Oct 22, 2024
20 checks passed
@Timeless0911 Timeless0911 deleted the create_rslib_1022 branch October 22, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants