-
Notifications
You must be signed in to change notification settings - Fork 48
feat: support watch rslib.config
to rebuild
#489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8c329d2
feat: restart
9aoy 3f644f9
fix: conflict
9aoy a712a08
feat: support restart when rslib config changed
9aoy 8ab1121
fix: update
9aoy 65ce9a4
chore: move to cli & support mf restart
9aoy 7dbe917
fix: merge conflict
9aoy b2428ed
fix: update
9aoy 76ec11b
fix: update
9aoy 9e66c9c
fix: update test
9aoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
import path from 'node:path'; | ||
import chokidar from 'chokidar'; | ||
import { color, debounce, isTTY } from '../utils/helper'; | ||
import { logger } from '../utils/logger'; | ||
|
||
export async function watchFilesForRestart( | ||
files: string[], | ||
restart: () => Promise<void>, | ||
): Promise<void> { | ||
if (!files.length) { | ||
return; | ||
} | ||
|
||
const watcher = chokidar.watch(files, { | ||
ignoreInitial: true, | ||
// If watching fails due to read permissions, the errors will be suppressed silently. | ||
ignorePermissionErrors: true, | ||
ignored: ['**/node_modules/**', '**/.git/**', '**/.DS_Store/**'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. chokidar v4 does not support glob, this will not work |
||
}); | ||
|
||
const callback = debounce( | ||
async (filePath) => { | ||
watcher.close(); | ||
|
||
await beforeRestart({ filePath }); | ||
await restart(); | ||
}, | ||
// set 300ms debounce to avoid restart frequently | ||
300, | ||
); | ||
|
||
watcher.on('add', callback); | ||
watcher.on('change', callback); | ||
watcher.on('unlink', callback); | ||
} | ||
|
||
type Cleaner = () => Promise<unknown> | unknown; | ||
|
||
let cleaners: Cleaner[] = []; | ||
|
||
/** | ||
* Add a cleaner to handle side effects | ||
*/ | ||
export const onBeforeRestart = (cleaner: Cleaner): void => { | ||
cleaners.push(cleaner); | ||
}; | ||
|
||
const clearConsole = () => { | ||
if (isTTY() && !process.env.DEBUG) { | ||
process.stdout.write('\x1B[H\x1B[2J'); | ||
} | ||
}; | ||
|
||
const beforeRestart = async ({ | ||
filePath, | ||
clear = true, | ||
}: { | ||
filePath?: string; | ||
clear?: boolean; | ||
} = {}): Promise<void> => { | ||
if (clear) { | ||
clearConsole(); | ||
} | ||
|
||
if (filePath) { | ||
const filename = path.basename(filePath); | ||
logger.info(`Restart because ${color.yellow(filename)} is changed.\n`); | ||
} else { | ||
logger.info('Restarting...\n'); | ||
} | ||
|
||
for (const cleaner of cleaners) { | ||
await cleaner(); | ||
} | ||
cleaners = []; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lazy import