Skip to content

fix(esm): disable module.parser.javascript.url #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Dec 2, 2024

Summary

Fix #499.

Disable module.parser.javascript.url as it's rarely used in library build scenario.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 5eaaa21
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/674d773ca212160008707b3a
😎 Deploy Preview https://deploy-preview-509--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework marked this pull request as draft December 2, 2024 09:05
@fi3ework fi3ework force-pushed the disable-url branch 2 times, most recently from a10a2fa to 58c2d8f Compare December 2, 2024 09:24
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #509 will not alter performance

Comparing disable-url (e4f3982) with main (cff510b)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework marked this pull request as ready for review December 2, 2024 09:47
@fi3ework fi3ework requested a review from Timeless0911 December 2, 2024 09:48
@Timeless0911
Copy link
Contributor

Why is this case be named format

@fi3ework fi3ework merged commit c8f15f4 into main Dec 2, 2024
18 checks passed
@fi3ework fi3ework deleted the disable-url branch December 2, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Target "node" output a static folder with bad exports
2 participants