Skip to content

feat: support load env #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat: support load env #518

merged 1 commit into from
Dec 4, 2024

Conversation

Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Dec 4, 2024 •
edited
Loading

Summary

  • Support load .env file
  • Add --env-dir cli option

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2024

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit e9f3852
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67501f2c9b5e9200082d4225
😎 Deploy Preview https://deploy-preview-518--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #518 will not alter performance

Comparing feat/load-env (e9f3852) with main (1bdbf5a)

Summary

✅ 5 untouched benchmarks

chenjiahan
chenjiahan approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

chenjiahan
chenjiahan reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check the performance degradation

@Timeless0911
Copy link
Contributor Author

Need to check the performance degradation

I have reruned the ci, it seems no degradation now.

@Timeless0911 Timeless0911 merged commit c54bed5 into main Dec 4, 2024
22 checks passed
@Timeless0911 Timeless0911 deleted the feat/load-env branch December 4, 2024 10:03
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@fi3ework fi3ework Awaiting requested review from fi3ework

Assignees
No one assigned
Labels
change: feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Timeless0911 @chenjiahan