Skip to content

feat: do not preserve nodeEnv when format is umd #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Dec 4, 2024

Summary

do not preserve nodeEnv when format is umd

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 77920a3
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/675039cd4b7e760008aee0dd
😎 Deploy Preview https://deploy-preview-520--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #520 will not alter performance

Comparing feat/umd-env (6273b20) with main (ecf9d6f)

Summary

✅ 5 untouched benchmarks

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit 8ca5c7b into main Dec 4, 2024
18 checks passed
@chenjiahan chenjiahan deleted the feat/umd-env branch December 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants