-
Notifications
You must be signed in to change notification settings - Fork 47
test: add alias replace externals tests in bundleless mode #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #581 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to also add new test cases that rewritten with resolve.alias
of the cases under tests/integration/externals/browser
which is using output.externals
now, since we're might encourage user to use resolve.alias
first in the future.
This case is a bundle case, so I add bundleless tests with |
aebdf0c
to
7958314
Compare
Summary
In bundleless mode, since there is no bundling concept, all modules will be externalized, so we will automatically replace the aliases in
resolve.alias
withoutput.externals
to ensure the final output is generated correctly.Related Links
Checklist