-
Notifications
You must be signed in to change notification settings - Fork 48
fix: pass server config to Rsbuild #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #584 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to document out public dir https://rsbuild.dev/zh/guide/basic/static-assets#public-%E7%9B%AE%E5%BD%95 in Rslib document as well. For now, there's not any word for it, and user won't know it without reading Rsbuild's doc.
We can introduce it in assets chapter after we support all assets feature well. |
ce61417
to
e168e55
Compare
Summary
We should pass
server
config to Rsbuild sincemf dev
and somepublicDir
feature need to configure it.Related Links
fix: #583
Checklist