Skip to content

fix: pass server config to Rsbuild #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

Timeless0911
Copy link
Contributor

Summary

We should pass server config to Rsbuild since mf dev and some publicDir feature need to configure it.

Related Links

fix: #583

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 58662cc
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67642258c8e34d0008258952
😎 Deploy Preview https://deploy-preview-584--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #584 will not alter performance

Comparing fix/should-pass-server (e168e55) with main (e667662)

Summary

✅ 5 untouched benchmarks

Copy link
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to document out public dir https://rsbuild.dev/zh/guide/basic/static-assets#public-%E7%9B%AE%E5%BD%95 in Rslib document as well. For now, there's not any word for it, and user won't know it without reading Rsbuild's doc.

@Timeless0911
Copy link
Contributor Author

I think we need to document out public dir https://rsbuild.dev/zh/guide/basic/static-assets#public-%E7%9B%AE%E5%BD%95 in Rslib document as well. For now, there's not any word for it, and user won't know it without reading Rsbuild's doc.

We can introduce it in assets chapter after we support all assets feature well.

@fi3ework fi3ework mentioned this pull request Dec 20, 2024
6 tasks
@fi3ework fi3ework force-pushed the fix/should-pass-server branch from ce61417 to e168e55 Compare December 20, 2024 04:16
@fi3ework fi3ework enabled auto-merge (squash) December 20, 2024 04:16
@Timeless0911 Timeless0911 merged commit b7a74f8 into main Dec 20, 2024
17 checks passed
@Timeless0911 Timeless0911 deleted the fix/should-pass-server branch December 20, 2024 05:09
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants