Skip to content

fix: detect possible glob pattern in bundle more #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

fi3ework
Copy link
Member

Summary

Close #632.

Glob pattern entry like .src/** must be set along with bundle: false.

I think we could do an active detection here.

image

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 654c9f3
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/6773afdfb064e500082a6010
😎 Deploy Preview https://deploy-preview-634--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework force-pushed the bundle-throw branch 3 times, most recently from b82cc07 to 7e78910 Compare December 31, 2024 09:43
@Timeless0911
Copy link
Contributor

Should we add ./src/**/* as default entry of bundleless mode?

@fi3ework
Copy link
Member Author

fi3ework commented Jan 2, 2025

Should we add ./src/**/* as default entry of bundleless mode?

Let's do it in a separated PR.

@Timeless0911 Timeless0911 merged commit 55767af into main Jan 3, 2025
16 checks passed
@Timeless0911 Timeless0911 deleted the bundle-throw branch January 3, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error occurred when packaging UMD files './src/**?__rslib_entry__ not found
2 participants