Skip to content

fix(ci): disable default extensions #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jan 30, 2024

Problem

By default GH Action shivammathur/setup-php@v2 does enable several extensions. The goal to test against missing gmp does not work because it was enabled by default.
Now disable all extensions and just enable the required.

Change

  • disable default extensions
  • test against an additional extension

test against an additional extension
Copy link
Member

@Minishlink Minishlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Minishlink Minishlink merged commit 29bd5b1 into web-push-libs:master Jan 30, 2024
@Rotzbua Rotzbua deleted the fix_ci branch January 30, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants