expose getLocalIdent #357
Merged
expose getLocalIdent #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.35% (diff: 100%)@@ master #357 diff @@
==========================================
Files 9 9
Lines 303 304 +1
Methods 41 41
Messages 0 0
Branches 66 67 +1
==========================================
+ Hits 298 299 +1
Misses 5 5
Partials 0 0
|
|
Without the module loading stuff it sounds doable. Just pass getLocalId via option/query. webpack 2 accepts non-JSON options. |
|
Add an example of usage to documentation, please. |
|
@sokra gotcha I'll remove that |
|
|
|
@sokra @MrCheater done |
sokra
approved these changes
Nov 17, 2016
|
can we merge & release :)? |
added 2 commits
November 17, 2016 22:00
|
Any idea when this will be released ? |
|
@esquevin Looks like it's included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #292