Skip to content

Issue 1002 #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 7, 2021
Merged

Issue 1002 #1028

merged 9 commits into from
Sep 7, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1002

Breaking Changes

No

Additional Info

Refactor code for future streaming and ETag/Modified-Since API

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #1028 (4d1d295) into master (0d55268) will decrease coverage by 0.61%.
The diff coverage is 94.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
- Coverage   97.99%   97.37%   -0.62%     
==========================================
  Files          10       10              
  Lines         299      343      +44     
  Branches      102      110       +8     
==========================================
+ Hits          293      334      +41     
- Misses          6        9       +3     
Impacted Files Coverage Δ
src/middleware.js 95.18% <93.33%> (-0.82%) ⬇️
src/utils/compatibleAPI.js 97.36% <97.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d55268...4d1d295. Read the comment docs.

@alexander-akait alexander-akait merged commit e8b21f0 into master Sep 7, 2021
@alexander-akait alexander-akait deleted the issue-1002 branch September 7, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant