Fix serving index.html on Windows #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using path.join for memory-fs leads to problems on Windows, because the path module will be path.win32 instead of path.unix, which of course uses backslash as the directory separator. We could explicitly import path.posix, but since this same JS file already includes a generic path.join that seems to work in enough cases for us, it seems OK to just use that.
|
Looks good to me. 👍 |
sokra
added a commit
that referenced
this pull request
Jan 12, 2016
Fix serving index.html on Windows
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I would be grateful if you could check this out and hopefully merge it at your earliest convenience, as I make heavy use of webpack-dev-server, and this bug is actually quite difficult to work around if you rely on HTML5-style pushState routing.
Many thanks.
Fixes #54.