Skip to content

Allow no entry point #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2018
Merged

Conversation

ryanclark
Copy link
Member

@ryanclark ryanclark commented Feb 17, 2018

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Fixes this issue #1308

Allows for webpack-dev-server to run with no config or no configured entry point, keeping the behaviour consistent with the webpack compiler.

Additional Info

This should eventually be moved out of webpack-dev-server as we've currently got two places setting the default entry point (this and WebpackOptionsDefaulter).

@codecov
Copy link

codecov bot commented Feb 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (webpack-4@9852a5f). Click here to learn what that means.
The diff coverage is 79.51%.

Impacted file tree graph

@@             Coverage Diff              @@
##             webpack-4    #1310   +/-   ##
============================================
  Coverage             ?   75.89%           
============================================
  Files                ?        9           
  Lines                ?      560           
  Branches             ?      146           
============================================
  Hits                 ?      425           
  Misses               ?      135           
  Partials             ?        0
Impacted Files Coverage Δ
lib/OptionsValidationError.js 60.9% <100%> (ø)
lib/plugins.js 55.88% <55.88%> (ø)
lib/DevServer.js 71.71% <71.71%> (ø)
lib/features.js 80.43% <80.43%> (ø)
lib/server.js 80.55% <80.55%> (ø)
lib/util.js 82.5% <82.5%> (ø)
lib/app.js 87.09% <87.09%> (ø)
lib/proxy.js 95.55% <95.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9852a5f...c99553a. Read the comment docs.

@ryanclark
Copy link
Member Author

Seems like Codacy isn't reviewing this as it's going into next rather than master.

@SpaceK33z
Copy link
Member

Thanks for your PR! Could you make it against webpack-4 branch? next is abandoned (see explanation).

I'll rename the next branch to make this more clear in the future.

@ryanclark ryanclark changed the base branch from next to webpack-4 February 17, 2018 10:07
@ryanclark ryanclark force-pushed the bugfix/default-options branch 3 times, most recently from 988d5dc to 0d6e83d Compare February 17, 2018 10:22
@ryanclark
Copy link
Member Author

@SpaceK33z all done!

@ryanclark ryanclark force-pushed the bugfix/default-options branch from 0d6e83d to c99553a Compare February 17, 2018 10:24
@SpaceK33z SpaceK33z merged commit e603e0d into webpack:webpack-4 Feb 17, 2018
@SpaceK33z
Copy link
Member

Awesome, thanks!!

@ryanclark ryanclark deleted the bugfix/default-options branch February 17, 2018 10:28
@ryanclark ryanclark changed the title Allow no publicPath or entry point Allow no entry point Feb 17, 2018
@TheLarkInn
Copy link
Member

@SpaceK33z did we publish this yet onto the beta? If not lets do it!! Happy to do so if you are tight on time.

@ryanclark
Copy link
Member Author

ryanclark commented Feb 24, 2018 via email

@SpaceK33z
Copy link
Member

Yes it is in beta.2 already :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants