-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Allow no entry point #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow no entry point #1310
Conversation
Codecov Report
@@ Coverage Diff @@
## webpack-4 #1310 +/- ##
============================================
Coverage ? 75.89%
============================================
Files ? 9
Lines ? 560
Branches ? 146
============================================
Hits ? 425
Misses ? 135
Partials ? 0
Continue to review full report at Codecov.
|
Seems like Codacy isn't reviewing this as it's going into |
Thanks for your PR! Could you make it against I'll rename the next branch to make this more clear in the future. |
988d5dc
to
0d6e83d
Compare
@SpaceK33z all done! |
0d6e83d
to
c99553a
Compare
Awesome, thanks!! |
@SpaceK33z did we publish this yet onto the beta? If not lets do it!! Happy to do so if you are tight on time. |
I believe it’s in 3.0.0-beta.2
…On Fri, 23 Feb 2018 at 23:59, Sean Larkin ***@***.***> wrote:
@SpaceK33z <https://github.com/spacek33z> did we publish this yet onto
the beta? If not lets do it!! Happy to do so if you are tight on time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1310 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHjhvRRje7DatcGr3DliYcvoWNAE8Lc_ks5tX1D0gaJpZM4SJHLO>
.
|
Yes it is in beta.2 already :). |
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Fixes this issue #1308
Allows for
webpack-dev-server
to run with no config or no configured entry point, keeping the behaviour consistent with the webpack compiler.Additional Info
This should eventually be moved out of
webpack-dev-server
as we've currently got two places setting the default entry point (this andWebpackOptionsDefaulter
).