Skip to content

refactor(eslint): make global-require to off #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jul 20, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

Because it is off in many places, so turn it off globally.

Breaking Changes

no

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner July 20, 2019 13:43
@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #2137 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2137   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files          32       32           
  Lines        1256     1256           
  Branches      358      358           
=======================================
  Hits         1164     1164           
  Misses         85       85           
  Partials        7        7
Impacted Files Coverage Δ
lib/servers/SockJSServer.js 96.66% <ø> (ø) ⬆️
lib/Server.js 97.37% <ø> (ø) ⬆️
lib/utils/getSocketClientPath.js 88.88% <ø> (ø) ⬆️
lib/utils/runBonjour.js 14.28% <ø> (ø) ⬆️
client-src/default/utils/reloadApp.js 100% <ø> (ø) ⬆️
lib/utils/getSocketServerImplementation.js 90.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45006e1...ba1814b. Read the comment docs.

@alexander-akait alexander-akait merged commit 75718b7 into master Jul 22, 2019
@alexander-akait alexander-akait deleted the feature/set-global-requre branch July 22, 2019 10:45
knagaitsev pushed a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants