fix: default value of the static option is static
#2897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BRAKING CHANGE: default value of the `static` option is `path.resolve(process.cwd(), 'static')`, previously `process.cwd()`
alexander-akait
commented
Dec 2, 2020
lib/utils/normalizeOptions.js
Outdated
| @@ -14,7 +15,7 @@ function normalizeOptions(compiler, options) { | |||
| : {}; | |||
|
|
|||
| const defaultOptionsForStatic = { | |||
| directory: process.cwd(), | |||
| directory: path.resolve(process.cwd(), 'static'), | |||
There was a problem hiding this comment.
I don't use check directory is exist to allow ability adding static dynamically and working with it without problems
Codecov Report
@@ Coverage Diff @@
## master #2897 +/- ##
==========================================
+ Coverage 92.52% 92.54% +0.01%
==========================================
Files 37 37
Lines 1258 1261 +3
Branches 333 334 +1
==========================================
+ Hits 1164 1167 +3
Misses 89 89
Partials 5 5
Continue to review full report at Codecov.
|
hiroppy
previously approved these changes
Dec 4, 2020
alexander-akait
commented
Dec 4, 2020
|
Let's merge, I think we need release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Existing
Motivation / Use-Case
fixes #2893
Breaking Changes
Yes
BREAKING CHANGE: default value of the
staticoption ispath.resolve(process.cwd(), 'dist'), previouslyprocess.cwd()Additional Info
no