refactor: imports #3299
refactor: imports #3299
Conversation
| @@ -980,6 +985,9 @@ class Server { | |||
| } | |||
|
|
|||
| serveMagicHtml(req, res, next) { | |||
| const getFilenameFromUrl = | |||
| require('webpack-dev-middleware/dist/utils/getFilenameFromUrl').default; | |||
There was a problem hiding this comment.
I think we should add this method to public webpack-dev-middleware API here https://github.com/webpack/webpack-dev-middleware/blob/master/src/index.js#L78, in future we should avoid import non public API
There was a problem hiding this comment.
Makes sense, will do 👍🏻
Codecov Report
@@ Coverage Diff @@
## master #3299 +/- ##
==========================================
+ Coverage 95.40% 95.56% +0.16%
==========================================
Files 34 34
Lines 1241 1241
Branches 354 354
==========================================
+ Hits 1184 1186 +2
Misses 51 51
+ Partials 6 4 -2
Continue to review full report at Codecov.
|
| const fs = require('graceful-fs'); | ||
| const ipaddr = require('ipaddr.js'); | ||
| const internalIp = require('internal-ip'); | ||
| const killable = require('killable'); | ||
| const chokidar = require('chokidar'); | ||
| const express = require('express'); |
There was a problem hiding this comment.
I think in future we reduce them more, good right now
| const https = require('https'); | ||
| const http = require('http'); |
There was a problem hiding this comment.
I'm not sure it'd make a difference, but I think we can move these below just like require('spdy').
For Bugs and Features; did you add new tests?
No, Already present.
Motivation / Use-Case
Reduce import at startup.
Breaking Changes
None
Additional Info
No