Skip to content

fix: add link for historyApiFallback options #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2021
Merged

fix: add link for historyApiFallback options #3390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,8 @@
"type": "boolean"
},
{
"type": "object"
"type": "object",
"description": "Options for `historyApiFallback`, description available at https://github.com/bripkens/connect-history-api-fallback#options"
}
],
"description": "When using the HTML5 History API, the index.html page will likely have to be served in place of any 404 responses. https://webpack.js.org/configuration/dev-server/#devserverhistoryapifallback"
Expand Down
3 changes: 2 additions & 1 deletion test/__snapshots__/validate-options.test.js.snap.webpack4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ exports[`options validate should throw an error on the "historyApiFallback" opti
Details:
* configuration.historyApiFallback should be a boolean.
* configuration.historyApiFallback should be an object:
object { … }"
object { … }
-> Options for \`historyApiFallback\`, description available at https://github.com/bripkens/connect-history-api-fallback#options"
`;

exports[`options validate should throw an error on the "host" option with '' value 1`] = `
Expand Down
3 changes: 2 additions & 1 deletion test/__snapshots__/validate-options.test.js.snap.webpack5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ exports[`options validate should throw an error on the "historyApiFallback" opti
Details:
* configuration.historyApiFallback should be a boolean.
* configuration.historyApiFallback should be an object:
object { … }"
object { … }
-> Options for \`historyApiFallback\`, description available at https://github.com/bripkens/connect-history-api-fallback#options"
`;

exports[`options validate should throw an error on the "host" option with '' value 1`] = `
Expand Down