Skip to content

Refactor remove unnecessary utils #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 2, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Will fix current tests

Motivation / Use-Case

Avoid unnecessary rules, avoid multiple require to speed up initial start

Breaking Changes

Yes, you need to use the latest webpack-cli version

Additional Info

No

snitin315
snitin315 previously approved these changes Jun 29, 2021
anshumanv
anshumanv previously approved these changes Jun 29, 2021
@snitin315
Copy link
Member

Let's fix CI.

@snitin315
Copy link
Member

@alexander-akait I can fix tests here if you don't have more changes locally.

@alexander-akait
Copy link
Member Author

@snitin315 I am WIP on this 👍 Anyway feel free to finish tests in any stale PRs

@alexander-akait alexander-akait dismissed stale reviews from anshumanv and snitin315 via e73ad5e July 2, 2021 14:19
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #3495 (e498a79) into master (caa78e6) will decrease coverage by 0.41%.
The diff coverage is 92.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3495      +/-   ##
==========================================
- Coverage   94.76%   94.34%   -0.42%     
==========================================
  Files          25       20       -5     
  Lines        1299     1291       -8     
  Branches      412      417       +5     
==========================================
- Hits         1231     1218      -13     
- Misses         64       68       +4     
- Partials        4        5       +1     
Impacted Files Coverage Δ
lib/Server.js 93.68% <92.95%> (-0.75%) ⬇️
lib/utils/DevServerPlugin.js 98.61% <0.00%> (ø)
lib/utils/normalizeOptions.js 97.17% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa78e6...e498a79. Read the comment docs.

@alexander-akait alexander-akait merged commit bb79030 into master Jul 2, 2021
@alexander-akait alexander-akait deleted the refactor-remove-unnecessary-utils branch July 2, 2021 16:04
@alexander-akait
Copy link
Member Author

We will restore coverage after finish - just more tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants