Skip to content

refactor: use latest terminology #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ yarn-error.log

.eslintcache

test/fixtures/contentbase-config/public/assets/non-exist.txt
test/fixtures/static-config/public/assets/non-exist.txt
test/fixtures/reload-config/main.css
test/fixtures/reload-config-2/main.css
!/test/fixtures/contentbase-config/public/node_modules
!/test/fixtures/static-config/public/node_modules
2 changes: 1 addition & 1 deletion test/fixtures/historyapifallback-3-config/index.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
contentBase file
static file
5 changes: 1 addition & 4 deletions test/server/host-option.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ const Server = require("../../lib/Server");
const config = require("../fixtures/simple-config/webpack.config");
const port = require("../ports-map")["host-option"];

const staticDirectory = path.resolve(
__dirname,
"../fixtures/contentbase-config"
);
const staticDirectory = path.resolve(__dirname, "../fixtures/static-config");
const internalIPv4 = internalIp.v4.sync();

describe("host option", () => {
Expand Down
4 changes: 2 additions & 2 deletions test/server/http2-option.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ const http2 = require("http2");
const webpack = require("webpack");
const request = require("supertest");
const Server = require("../../lib/Server");
const config = require("../fixtures/contentbase-config/webpack.config");
const config = require("../fixtures/static-config/webpack.config");
const port = require("../ports-map")["http2-option"];

const staticDirectory = path.resolve(
__dirname,
"../fixtures/contentbase-config/public"
"../fixtures/static-config/public"
);

describe('"http2" option', () => {
Expand Down
18 changes: 9 additions & 9 deletions test/server/https-option.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ const fs = require("graceful-fs");
const request = require("supertest");
const webpack = require("webpack");
const Server = require("../../lib/Server");
const config = require("../fixtures/contentbase-config/webpack.config");
const config = require("../fixtures/static-config/webpack.config");
const { skipTestOnWindows } = require("../helpers/conditional-test");
const port = require("../ports-map")["https-option"];

const httpsCertificateDirectory = path.resolve(
__dirname,
"../fixtures/https-certificate"
);
const contentBasePublic = path.resolve(
const staticDirectory = path.resolve(
__dirname,
"../fixtures/contentbase-config/public"
"../fixtures/static-config/public"
);

describe("https option", () => {
Expand All @@ -29,7 +29,7 @@ describe("https option", () => {
server = new Server(
{
static: {
directory: contentBasePublic,
directory: staticDirectory,
watch: false,
},
https: true,
Expand Down Expand Up @@ -62,7 +62,7 @@ describe("https option", () => {
server = new Server(
{
static: {
directory: contentBasePublic,
directory: staticDirectory,
watch: false,
},
https: {
Expand Down Expand Up @@ -108,7 +108,7 @@ describe("https option", () => {

server = new Server(
{
static: contentBasePublic,
static: staticDirectory,
https: {
cacert: path.join(httpsCertificateDirectory, "ca.pem"),
pfx: path.join(httpsCertificateDirectory, "server.pfx"),
Expand Down Expand Up @@ -149,7 +149,7 @@ describe("https option", () => {
server = new Server(
{
static: {
directory: contentBasePublic,
directory: staticDirectory,
watch: false,
},
https: {
Expand Down Expand Up @@ -188,7 +188,7 @@ describe("https option", () => {
server = new Server(
{
static: {
directory: contentBasePublic,
directory: staticDirectory,
watch: false,
},
https: {
Expand Down Expand Up @@ -236,7 +236,7 @@ describe("https option", () => {
server = new Server(
{
static: {
directory: contentBasePublic,
directory: staticDirectory,
watch: false,
},
https: {
Expand Down
5 changes: 1 addition & 4 deletions test/server/port-option.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ const Server = require("../../lib/Server");
const config = require("../fixtures/simple-config/webpack.config");
const port = require("../ports-map")["port-option"];

const staticDirectory = path.resolve(
__dirname,
"../fixtures/contentbase-config"
);
const staticDirectory = path.resolve(__dirname, "../fixtures/static-config");

describe('"port" option', () => {
let server = null;
Expand Down
7 changes: 2 additions & 5 deletions test/server/static-directory-option.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@ const webpack = require("webpack");
const request = require("supertest");
const Server = require("../../lib/Server");
const testServer = require("../helpers/test-server");
const config = require("../fixtures/contentbase-config/webpack.config");
const config = require("../fixtures/static-config/webpack.config");
const port = require("../ports-map")["static-directory-option"];

const staticDirectory = path.resolve(
__dirname,
"../fixtures/contentbase-config"
);
const staticDirectory = path.resolve(__dirname, "../fixtures/static-config");
const publicDirectory = path.resolve(staticDirectory, "public");
const otherPublicDirectory = path.resolve(staticDirectory, "other");

Expand Down
7 changes: 2 additions & 5 deletions test/server/static-publicPath-option.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,10 @@ const path = require("path");
const request = require("supertest");
const webpack = require("webpack");
const Server = require("../../lib/Server");
const config = require("../fixtures/contentbase-config/webpack.config");
const config = require("../fixtures/static-config/webpack.config");
const port = require("../ports-map")["static-public-path-option"];

const staticDirectory = path.resolve(
__dirname,
"../fixtures/contentbase-config"
);
const staticDirectory = path.resolve(__dirname, "../fixtures/static-config");
const publicDirectory = path.resolve(staticDirectory, "public");
const otherPublicDirectory = path.resolve(staticDirectory, "other");
const staticPublicPath = "/serve-content-base-at-this-url";
Expand Down
7 changes: 2 additions & 5 deletions test/server/watchFiles-option.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,10 @@ const webpack = require("webpack");
const fs = require("graceful-fs");
const chokidar = require("chokidar");
const Server = require("../../lib/Server");
const config = require("../fixtures/contentbase-config/webpack.config");
const config = require("../fixtures/static-config/webpack.config");
const port = require("../ports-map")["watch-files-option"];

const watchDir = path.resolve(
__dirname,
"../fixtures/contentbase-config/public"
);
const watchDir = path.resolve(__dirname, "../fixtures/static-config/public");

describe("'watchFiles' option", () => {
let server;
Expand Down