test: add e2e tests for https option
#3776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
| @@ -20,6 +20,7 @@ function runBrowser(config) { | |||
| puppeteer | |||
| .launch({ | |||
| headless: true, | |||
| ignoreHTTPSErrors: true, | |||
There was a problem hiding this comment.
Due invalid localhost cert? Let's add comment about it
Codecov Report
@@ Coverage Diff @@
## master #3776 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 14 14
Lines 1321 1321
Branches 463 463
=======================================
Hits 1229 1229
Misses 85 85
Partials 7 7 Continue to review full report at Codecov.
|
alexander-akait
previously approved these changes
Sep 2, 2021
|
Note, coverage should be not changed when we rewrite tests, because we can missing something from old tests |
|
All green ✅ |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
add e2e tests for
httpsoption.Breaking Changes
No
Additional Info
puppeteer having issues accepting SSL with
requestCert: true, throwing errornet::ERR_BAD_SSL_CLIENT_AUTH_CERT, hence testing withsupertestfor this case.