Skip to content

test: move test case to appropriate place #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2021
Merged

test: move test case to appropriate place #3871

merged 2 commits into from
Sep 24, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Sep 23, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Movehot: false test to hot-option.test.js from client-option.test.js

Breaking Changes

None

Additional Info

No

expect(response.status).toEqual(200);
expect(response.text).not.toContain("webpack/hot/dev-server.js");
});
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add test for open browser, we should see no output for hot log

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is already present -

{
title: "should not refresh content when hot and no live reload disabled",
options: {
hot: false,
liveReload: false,
},
},

{
title: "should work and refresh content using live reload",
options: {
liveReload: true,
hot: false,
},
},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, looks like duplicate test, but here we test webpack/hot/dev-server.js, I am fine with this

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #3871 (19b3678) into master (22fa60b) will not change coverage.
The diff coverage is n/a.

❗ Current head 19b3678 differs from pull request most recent head 52d948a. Consider uploading reports for the commit 52d948a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3871   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files          14       14           
  Lines        1334     1334           
  Branches      467      467           
=======================================
  Hits         1237     1237           
  Misses         89       89           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fa60b...52d948a. Read the comment docs.

@snitin315 snitin315 merged commit 4962424 into master Sep 24, 2021
@snitin315 snitin315 deleted the rm-dup-test branch September 24, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants