-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test: move test case to appropriate place #3871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
expect(response.status).toEqual(200); | ||
expect(response.text).not.toContain("webpack/hot/dev-server.js"); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add test for open browser, we should see no output for hot log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is already present -
webpack-dev-server/test/e2e/hot-and-live-reload.test.js
Lines 52 to 58 in 19b3678
{ | |
title: "should not refresh content when hot and no live reload disabled", | |
options: { | |
hot: false, | |
liveReload: false, | |
}, | |
}, |
webpack-dev-server/test/e2e/hot-and-live-reload.test.js
Lines 67 to 73 in 19b3678
{ | |
title: "should work and refresh content using live reload", | |
options: { | |
liveReload: true, | |
hot: false, | |
}, | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, looks like duplicate test, but here we test webpack/hot/dev-server.js
, I am fine with this
Codecov Report
@@ Coverage Diff @@
## master #3871 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 14 14
Lines 1334 1334
Branches 467 467
=======================================
Hits 1237 1237
Misses 89 89
Partials 8 8 Continue to review full report at Codecov.
|
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
Move
hot: false
test tohot-option.test.js
fromclient-option.test.js
Breaking Changes
None
Additional Info
No