增加日志打印 #133
Merged
增加日志打印 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xy-peng
reviewed
Apr 21, 2022
src/main/java/com/wechat/pay/contrib/apache/httpclient/auth/CertificatesVerifier.java
Outdated
Show resolved
Hide resolved
xy-peng
reviewed
Apr 21, 2022
src/main/java/com/wechat/pay/contrib/apache/httpclient/WechatPayUploadHttpPost.java
Outdated
Show resolved
Hide resolved
xy-peng
reviewed
Apr 21, 2022
src/main/java/com/wechat/pay/contrib/apache/httpclient/SignatureExec.java
Outdated
Show resolved
Hide resolved
xy-peng
reviewed
Apr 21, 2022
| // 错误应答需要打日志 | ||
| log.error("request header[{}]", Arrays.toString(request.getAllHeaders())); | ||
| HttpEntity entity = getRequestEntity(request); | ||
| if (entity != null && !isUploadHttpPost(request)) { |
There was a problem hiding this comment.
if isEntityEnclosing && !isUploadHttpPost {
entity = request.getentity()
EntityUtils.toString(entity)
log.error(...)
}There was a problem hiding this comment.
好像没有其他地方用到，是否现在没有抽象成Util的必要
There was a problem hiding this comment.
是apache httpclient 本来就提供了 toString 方法……
|
@lianup 顺便修复下README-开始的 typo 吧 import com.wechat.pay.contrib.apache.httpclient.WechatPayHttpClientBuilder;
//...
WechatPayHttpClientBuilder builder = WechatPayHttpClientBuilder.create()
.withMerchant(merchantId, merchantSerialNumber, merchantPrivateKey)
.withWechatPay(wechatpayCertificates);
// ... 接下来，你仍然可以通过builder设置各种参数，来配置你的HttpClient
// 通过WechatPayHttpClientBuilder构造的HttpClient，会自动的处理签名和验签
CloseableHttpClient httpClient = builder.build();
// 后面跟使用Apache HttpClient一样
ClosableHttpResponse response = httpClient.execute(...);
^^^
CloseableHttpClient，少了个e |
| // 对成功应答验签 | ||
| StatusLine statusLine = response.getStatusLine(); | ||
| if (statusLine.getStatusCode() >= SC_OK && statusLine.getStatusCode() < SC_MULTIPLE_CHOICES) { | ||
| convertToRepeatableResponseEntity(response); | ||
| if (!validator.validate(response)) { | ||
| throw new HttpException("应答的微信支付签名验证失败"); | ||
| } | ||
| } else { | ||
| // 错误应答需要打日志 | ||
| log.error("request header[{}]", Arrays.toString(request.getAllHeaders())); |
There was a problem hiding this comment.
header → headers。
日志这里加上具体的错误信息，不只是给headers。
| HttpEntity entity = ((HttpEntityEnclosingRequest) request).getEntity(); | ||
| ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); | ||
| entity.writeTo(outputStream); | ||
| log.error("request body[{}]", outputStream.toString("UTF-8")); |
There was a problem hiding this comment.
日志这里加上具体的错误信息，不只是给headers。
| @@ -57,7 +60,11 @@ protected boolean verify(X509Certificate certificate, byte[] message, String sig | |||
| public boolean verify(String serialNumber, byte[] message, String signature) { | |||
| BigInteger val = new BigInteger(serialNumber, 16); | |||
| X509Certificate cert = certificates.get(val); | |||
| return cert != null && verify(cert, message, signature); | |||
| if (cert == null) { | |||
| log.debug("找不到证书序列号对应的证书，序列号：{}", serialNumber); | |||
There was a problem hiding this comment.
- 用英文描述。
- 加上什么上下文信息（什么情况下找不到）。
- 这应该是个error log，不是debug log？
lianup
force-pushed
the
master
branch
2 times, most recently
from
abb16bc to
0227fad
Compare
xy-peng
approved these changes
Apr 22, 2022
Eric-Lee-Handyman
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.