统一文档和测试用例中的变量命名 #142
Merged
统一文档和测试用例中的变量命名 #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianup
force-pushed
the
master
branch
2 times, most recently
from
d0cf0aa to
caaf852
Compare
xy-peng
requested changes
May 12, 2022
README.md
Outdated
| @@ -169,32 +169,32 @@ import com.wechat.pay.contrib.apache.httpclient.WechatPayHttpClientBuilder; | |||
| import com.wechat.pay.contrib.apache.httpclient.Credentials; | |||
|
|
|||
| // ... | |||
| Credentials credentials = new WechatPay2Credentials(merchantId, new Signer() { | |||
| Credentials credentials = new WechatPay2Credentials(mchId, new Signer() { | |||
README.md
Outdated
| @@ -73,7 +73,7 @@ CloseableHttpResponse response = httpClient.execute(...); | |||
| + `merchantId`商户号。 | |||
| + `merchantSerialNumber`商户API证书的证书序列号。 | |||
| + `merchantPrivateKey`商户API私钥，如何加载商户API私钥请看[常见问题](#如何加载商户私钥)。 | |||
| + `wechatpayCertificates`微信支付平台证书。你也可以使用后面章节提到的“[定时更新平台证书功能](#定时更新平台证书功能)”，而不需要关心平台证书的来龙去脉。 | |||
| + `wechatPayCertList`微信支付平台证书列表。你也可以使用后面章节提到的“[定时更新平台证书功能](#定时更新平台证书功能)”，而不需要关心平台证书的来龙去脉。 | |||
There was a problem hiding this comment.
wechatPayCertificateList 避免缩写吧
README.md
Outdated
| @@ -169,32 +169,32 @@ import com.wechat.pay.contrib.apache.httpclient.WechatPayHttpClientBuilder; | |||
| import com.wechat.pay.contrib.apache.httpclient.Credentials; | |||
|
|
|||
| // ... | |||
| Credentials credentials = new WechatPay2Credentials(merchantId, new Signer() { | |||
| Credentials credentials = new WechatPay2Credentials(mchId, new Signer() { | |||
There was a problem hiding this comment.
mchId → merchantId
README.md
Outdated
| @Override | ||
| public Signer.SignatureResult sign(byte[] message) { | ||
| // ... call your sign-RPC, then return sign & serial number | ||
| } | ||
| }); | ||
| WechatPayHttpClientBuilder builder = WechatPayHttpClientBuilder.create() | ||
| .withCredentials(credentials) | ||
| .withWechatPay(wechatpayCertificates); | ||
| .withWechatPay(wechatPayCertList); |
There was a problem hiding this comment.
wechatPayCertList → wechatpayCertificateList
xy-peng
approved these changes
May 12, 2022
Eric-Lee-Handyman
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.