CardSection - remove 'source' (use 'imageSource') (#1551)

Author: Inbal-Tish

generatedTypes/src/components/card/CardSection.d.ts

@@ -32,7 +32,6 @@ export declare type CardSectionProps = ViewProps & {
      * Will be used for the background when provided
      */
     imageSource?: ImageSourcePropType;
-    source?: ImageSourcePropType;
     /**
      * The style for the background image
      */
@@ -68,7 +67,6 @@ declare const _default: React.ComponentClass<ViewProps & {
      * Will be used for the background when provided
      */
     imageSource?: ImageSourcePropType | undefined;
-    source?: ImageSourcePropType | undefined;
     /**
      * The style for the background image
      */

src/components/card/CardSection.tsx

@@ -1,13 +1,13 @@
 import _ from 'lodash';
 import React, {PureComponent} from 'react';
 import {StyleSheet, ViewStyle, ImageStyle, ImageSourcePropType, StyleProp} from 'react-native';
-import {LogService} from '../../services';
 import {asBaseComponent} from '../../commons/new';
 import View, {ViewProps} from '../view';
 import Text, {TextProps} from '../text';
 import Image, {ImageProps} from '../image';
 import asCardChild, {asCardChildProps} from './asCardChild';
 
+
 type ContentType = TextProps & {text?: string};
 
 export type CardSectionProps = ViewProps & {
@@ -36,7 +36,6 @@ export type CardSectionProps = ViewProps & {
    * Will be used for the background when provided
    */
   imageSource?: ImageSourcePropType;
-  source?: ImageSourcePropType; // TODO: remove after deprecation
   /**
    * The style for the background image
    */
@@ -56,14 +55,6 @@ type Props = CardSectionProps & asCardChildProps;
 class CardSection extends PureComponent<Props> {
   static displayName = 'Card.Section';
 
-  constructor(props: Props) {
-    super(props);
-
-    if (props.source) {
-      LogService.deprecationWarn({component: 'CardSection', oldProp: 'source', newProp: 'imageSource'});
-    }
-  }
-
   renderContent = () => {
     const {content, leadingIcon, trailingIcon, contentStyle, testID} = this.props;
     if (!leadingIcon && !trailingIcon && _.isEmpty(content)) {
@@ -92,15 +83,14 @@ class CardSection extends PureComponent<Props> {
   };
 
   renderImage = () => {
-    const {source, imageSource, imageStyle, imageProps, testID} = this.props;
-    const finalSource = imageSource || source;
+    const {imageSource, imageStyle, imageProps, testID} = this.props;
 
     // not actually needed, instead of adding ts-ignore
-    if (finalSource) {
+    if (imageSource) {
       return (
         <Image
           testID={`${testID}.image`}
-          source={finalSource}
+          source={imageSource}
           style={imageStyle}
           customOverlayContent={this.renderContent()}
           {...imageProps}
@@ -111,18 +101,16 @@ class CardSection extends PureComponent<Props> {
 
   render() {
     const {
-      source,
       imageSource,
       context: {borderStyle},
       style,
       ...others
     } = this.props;
-    const finalSource = imageSource || source;
 
     return (
       <View style={[styles.container, borderStyle, style]} {...others}>
-        {finalSource && this.renderImage()}
-        {!finalSource && this.renderContent()}
+        {imageSource && this.renderImage()}
+        {!imageSource && this.renderContent()}
       </View>
     );
   }