Card section remove deprecated prop #1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Sep 13, 2021
| @@ -36,7 +36,6 @@ export type CardSectionProps = ViewProps & { | |||
| * Will be used for the background when provided | |||
| */ | |||
| imageSource?: ImageSourcePropType; | |||
| source?: ImageSourcePropType; // TODO: remove after deprecation | |||
There was a problem hiding this comment.
I found a usage in OneApp that still use the source prop.
https://github.com/wix-private/restaurants/blob/af89e6db06c8e694e4d38719466ec88a93d5ffdc/one-app-restaurants-member/src/orders/screens/DispatchTypeScreen/components/DispatchTypeComponent.tsx#L51
There was a problem hiding this comment.
That's wired. The change was already in the first V6 branch...
There was a problem hiding this comment.
I asked @guywix to fix it.
There was a problem hiding this comment.
Did he respond?
Does he have an ETA?
We can still release v6 to community and Guy will have time till our next private version (which will take v6)
There was a problem hiding this comment.
He didn't, but that's what I though as we didn't plan to release in private just yet
There was a problem hiding this comment.
Ok, but it's important to remember not to miss it.
Anyway, ill approve
ethanshar
approved these changes
Sep 13, 2021
ethanshar
added a commit
that referenced
this pull request
Sep 14, 2021
* Major version bump * Rename components props interface (#1534) * Renaming components props (<Component>PropTypes is now <Component>Props). * generating types * Removing from generatedTypes/index.d.ts file * SelectableComponent - Removing deprecated component (#1536) * SelectableComponent - removing component * removing from types * TagsInput - removing component (#1538) * AnimatableManager - removing component (#1537) * AnimatableManager - removing component and it usages * remove import * ThemeManager - removing 'setTheme' (#1539) * CardImage - remove deprecated props (#1541) * CardImage - removing deprecated props * remove import * KeyboardTrackingView (iOS)- changed 'useSafeArea' default to 'false' (#1543) * PanningProviderDirection - removing type (use PanningDirections) (#1542) * Avatar and Badge - props deprecation (#1540) * Badge and Avatar - removing deprecated props and enum, and their usages * fix demo screens * removing Animatable refs * fix prop description * types * react-native-animatable - removing dep (#1544) * Colors new presets (#1546) * change color palette to more accessible colors; Remove DARKS palette and replacing usage with GREYS * update tests * types * pr comments * TabBar - start deprecation and remove usages (#1545) * TabBarItem - remove deprecated prop (#1554) * StateScreen - remove deprecated props: 'source' (use 'imageSource'), 'testId' (use RN's 'testID'). (#1553) * Dialog remove deprecated prop (#1550) * Dialog - remove 'onModalDismissed' (use 'onDialogDismissed') * remove 'migrate' prop from demos * CardSection - remove 'source' (use 'imageSource') (#1551) * Stepper new design (#1547) * Stepper - new component design and API * types * export types * fix parameter * fix typings exports * fix imports * removing unused imports * fix imports * Progress bar new design (#1549) * ProgressBar - new component design and API * customElement demo * borderRadius * demo - texts style * fix merge * Remove old implementations of TabController (#1555) * Avatar - revert 'imageSource' deletion (#1557) * Avatar - restore warning on 'imageSource' deprecated prop * V6 migration guide (#1558) Co-authored-by: Ethan Sharabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CardSection - remove deprecated prop: 'sorce' (use 'imageSource').
Changelog
CardSection - remove deprecated prop: 'sorce' (use 'imageSource').