TextInput - keyboardType="number-pad" with external keyboard (#2978)

M-i-k-e-l · web-flow · commit 941543436c38 · 2024-03-13T09:31:24.000+02:00
diff --git a/lib/ios/reactnativeuilib/keyboardtrackingview/ObservingInputAccessoryViewTemp.m b/lib/ios/reactnativeuilib/keyboardtrackingview/ObservingInputAccessoryViewTemp.m
@@ -129,7 +129,9 @@ - (void)_keyboardDidShowNotification:(NSNotification*)notification
 {
     _keyboardState = KeyboardStateShown;
     
-    [self invalidateIntrinsicContentSize];
+    if (_keyboardHeight > 0) { //prevent triggering observeValueForKeyPath if an external keyboard is in use
+        [self invalidateIntrinsicContentSize];
+    }
 }
 
 - (void)_keyboardWillHideNotification:(NSNotification*)notification
diff --git a/lib/package.json b/lib/package.json
@@ -1,6 +1,6 @@
 {
   "name": "uilib-native",
-  "version": "4.1.2",
+  "version": "4.1.3",
   "homepage": "https://github.com/wix/react-native-ui-lib",
   "description": "uilib native components (separated from js components)",
   "main": "components/index.js",

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,9 @@ - (void)_keyboardDidShowNotification:(NSNotification*)notification`
`129`	`129`	`{`
`130`	`130`	`_keyboardState = KeyboardStateShown;`
`131`	`131`
`132`		`- [self invalidateIntrinsicContentSize];`
	`132`	`+ if (_keyboardHeight > 0) { //prevent triggering observeValueForKeyPath if an external keyboard is in use`
	`133`	`+ [self invalidateIntrinsicContentSize];`
	`134`	`+ }`
`133`	`135`	`}`
`134`	`136`
`135`	`137`	`- (void)_keyboardWillHideNotification:(NSNotification*)notification`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "uilib-native",`
`3`		`- "version": "4.1.2",`
	`3`	`+ "version": "4.1.3",`
`4`	`4`	`"homepage": "https://github.com/wix/react-native-ui-lib",`
`5`	`5`	`"description": "uilib native components (separated from js components)",`
`6`	`6`	`"main": "components/index.js",`