Skip to content

KeyboardAwareInsetsView - with TextInput keyboardType="number-pad" with external keyboard #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Mar 12, 2024

Description

KeyboardAwareInsetsView - fix application halting when TextInput with keyboardType=“number-pad” with external keyboard (not sure if Apple keyboard reproduces)

Real device only
Example screen:

import React, {Component} from 'react';
import {ScrollView, TextInput} from 'react-native';
import {Keyboard, View} from 'react-native-ui-lib';

export default class PlaygroundScreen extends Component {
  render() {
    return (
      <ScrollView contentContainerStyle={{flex: 1}}>
        <View flex centerV>
          <TextInput placeholder={'TextInput'} keyboardType="number-pad"/>
          <Keyboard.KeyboardAwareInsetsView/>
        </View>
      </ScrollView>
    );
  }
}

Changelog

KeyboardAwareInsetsView - fix application halting when TextInput with keyboardType=“number-pad” with external keyboard (not sure if Apple keyboard reproduces)

Additional info

Ticket 4007

@M-i-k-e-l M-i-k-e-l added the Important for Next Release PR that must be included in the release version label Mar 12, 2024
@M-i-k-e-l M-i-k-e-l requested a review from Inbal-Tish March 12, 2024 14:15
@Inbal-Tish Inbal-Tish merged commit 9415434 into master Mar 13, 2024
@Inbal-Tish Inbal-Tish deleted the fix/text-input-num-pad-with-external-keyboard branch March 13, 2024 07:31
@M-i-k-e-l M-i-k-e-l changed the title TextInput - keyboardType="number-pad" with external keyboard KeyboardAwareInsetsView - with TextInput keyboardType="number-pad" with external keyboard Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants