Fix misuse of new event emitter API in useOrientation hook (#1661)

* Fix misue of new event emitter API in useOrientation hook

* keep listener inside clouser instead of using ref

* Fix lint error

Author: ethanshar

src/hooks/useOrientation/index.ts

@@ -14,8 +14,8 @@ const useOrientation = ({onOrientationChange}: UseOrientationProps = {}) => {
   }, []);
 
   useEffect(() => {
-    Constants.addDimensionsEventListener(orientationChangeListener);
-    return () => Constants.removeDimensionsEventListener(orientationChangeListener);
+    const listener = Constants.addDimensionsEventListener(orientationChangeListener);
+    return () => Constants.removeDimensionsEventListener(listener);
   }, []);
 
   useDidUpdate(() => {