Fix misuse of new event emitter API in useOrientation hook #1661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
the
Important for Next Release
M-i-k-e-l
reviewed
Nov 14, 2021
src/hooks/useOrientation/index.ts
Outdated
|
|
||
| const orientationChangeListener = useCallback(() => { | ||
| setOrientation(Constants.orientation); | ||
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| Constants.addDimensionsEventListener(orientationChangeListener); | ||
| return () => Constants.removeDimensionsEventListener(orientationChangeListener); | ||
| listener.current = Constants.addDimensionsEventListener(orientationChangeListener); |
There was a problem hiding this comment.
I don't think we need the useRef here:
const listener = Constants.addDimensionsEventListener(orientationChangeListener);
There was a problem hiding this comment.
Good point 👌
Fixed
M-i-k-e-l
approved these changes
Nov 14, 2021
ethanshar
added a commit
that referenced
this pull request
Nov 15, 2021
* Fix misue of new event emitter API in useOrientation hook * keep listener inside clouser instead of using ref * Fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix misuse of new event emitter API in useOrientation hook
Changelog
Fix event emitter warning coming from useOrientation hook