Skip to content

Commit f0ff7ac

Browse files
authored
remove NativePicker usage and files (#3088)
* remove NativePicker usage and files * rename state in the screen * removed useNativePicker from setup.md * removed react-native-picker requirement from setup.md
1 parent 990079b commit f0ff7ac

File tree

8 files changed

+3
-163
lines changed

8 files changed

+3
-163
lines changed

demo/src/demoApp.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,6 @@ import Storage, {DEFAULT_SCREEN} from './storage';
1414
// gold: '#FFD700',
1515
// });
1616

17-
// ThemeManager.setComponentTheme('Picker', (props) => {
18-
// if (props.useNativePicker) {
19-
// return {
20-
// topBarProps: {
21-
// doneLabel: Constants.isIOS ? 'Done2' : 'OK2',
22-
// cancelLabel: Constants.isIOS ? 'Cancel2' : 'CANCEL2',
23-
// },
24-
// };
25-
// }
26-
// });
27-
2817
// const customAnimationsDefinitions = {
2918
// customAnimation1: {
3019
// from: {opacity: 0, translateY: 20},

demo/src/screens/componentScreens/PickerScreen.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export default class PickerScreen extends Component {
9191
language2: options[2].value,
9292
languages: [],
9393
option: undefined,
94-
nativePickerValue: 'java',
94+
wheelPickerValue: 'java',
9595
dialogPickerValue: 'java',
9696
customModalValues: [],
9797
filter: filters[0].value,
@@ -157,8 +157,8 @@ export default class PickerScreen extends Component {
157157
label="Wheel Picker"
158158
placeholder="Pick a Language"
159159
useWheelPicker
160-
value={this.state.nativePickerValue}
161-
onChange={nativePickerValue => this.setState({nativePickerValue})}
160+
value={this.state.wheelPickerValue}
161+
onChange={wheelPickerValue => this.setState({wheelPickerValue})}
162162
trailingAccessory={<Icon source={dropdown}/>}
163163
items={options}
164164
/>

docs/getting-started/setup.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ The following are optional dependencies:
4444
- @react-native-community/blur
4545
- @react-native-community/datetimepicker
4646
- @react-native-community/netinfo
47-
- @react-native-picker/picker
4847

4948

5049
## Install Native Dependencies
@@ -60,7 +59,6 @@ Some of the components are using the native dependencies listed below - those ar
6059
- "@react-native-community/blur": ">=3.4.1" (required for Card component when passing `enableBlur` prop)
6160
- "@react-native-community/datetimepicker": "^2.1.0"
6261
- "@react-native-community/netinfo": "^5.6.2" (required for ConnectionStatusBar component)
63-
- "@react-native-picker/picker": "^1.9.4" (required for Picker component when passing `useNativePicker` prop)
6462

6563
## Demo App
6664

src/components/picker/NativePicker.js

Lines changed: 0 additions & 134 deletions
This file was deleted.

src/components/picker/api/picker.api.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"images": [
88
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/Default.gif?raw=true",
99
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/MultiPicker.gif?raw=true",
10-
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/NativePicker.gif?raw=true",
1110
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/DialogPicker.gif?raw=true",
1211
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/CustomPicker.gif?raw=true"
1312
],

src/components/picker/api/pickerItem.api.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
"images": [
77
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/Default.gif?raw=true",
88
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/MultiPicker.gif?raw=true",
9-
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/NativePicker.gif?raw=true",
109
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/DialogPicker.gif?raw=true",
1110
"https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/CustomPicker.gif?raw=true"
1211
],

src/components/picker/index.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import TextField from '../textField';
1414
import Icon from '../icon';
1515
import View from '../view';
1616
import Text from '../text';
17-
// import NativePicker from './NativePicker';
1817
import PickerItemsList from './PickerItemsList';
1918
import PickerItem from './PickerItem';
2019
import PickerContext from './PickerContext';
@@ -62,7 +61,6 @@ const Picker = React.forwardRef((props: PickerProps, ref) => {
6261
searchPlaceholder,
6362
renderCustomSearch,
6463
renderCustomDialogHeader,
65-
// useNativePicker,
6664
useWheelPicker,
6765
useDialog,
6866
renderPicker,
@@ -293,10 +291,6 @@ const Picker = React.forwardRef((props: PickerProps, ref) => {
293291
}
294292
};
295293

296-
// if (useNativePicker) {
297-
// return <NativePicker {...themeProps}/>;
298-
// }
299-
300294
return (
301295
//TODO : fix the ExpandableOverlay ts error
302296
<PickerContext.Provider value={contextValue}>

src/components/picker/types.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,6 @@ export type PickerBaseProps = Omit<NewTextFieldProps, 'value' | 'onChange'> & {
151151
* Render a custom header for Picker's dialog
152152
*/
153153
renderCustomDialogHeader?: (callbacks: {onDone?: () => void, onCancel?: ()=> void}) => React.ReactElement;
154-
// /**
155-
// * @deprecated pass useWheelPicker prop instead
156-
// * Allow to use the native picker solution (different style for iOS and Android)
157-
// */
158-
// useNativePicker?: boolean;
159154
/**
160155
* Use wheel picker instead of a list picker
161156
*/

0 commit comments

Comments
 (0)