Skip to content

remove NativePicker usage and files #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2024
Merged

remove NativePicker usage and files #3088

merged 4 commits into from
Jun 2, 2024

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented May 23, 2024 •
edited
Loading

Description

Remove NativePicker files and usages.
Related PR - removing usage of useNativePicker from usePickerMigrationWarning.

Changelog

Remove NativePicker files and usages.

Additional info

MDAS

@adids1221 adids1221 marked this pull request as ready for review May 26, 2024 07:30
@adids1221 adids1221 requested a review from M-i-k-e-l May 26, 2024 07:30
M-i-k-e-l
M-i-k-e-l reviewed May 26, 2024
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please search for nativepicker and remove remaining instances (except in v7.md)

@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l May 26, 2024
@adids1221
Copy link
Contributor Author

Please search for nativepicker and remove remaining instances (except in v7.md)

@M-i-k-e-l this PR should be merged after merging this PR.

@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 May 28, 2024
@M-i-k-e-l
Copy link
Collaborator

I still see useNativePicker in the setup.md

@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l May 29, 2024
@adids1221 adids1221 requested a review from M-i-k-e-l May 30, 2024 13:58
@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 May 30, 2024
@M-i-k-e-l M-i-k-e-l merged commit f0ff7ac into master Jun 2, 2024
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the infra/NativePicker_remove branch June 2, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adids1221 @M-i-k-e-l