deprecate children, migrate picker props #3078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
May 26, 2024
Inbal-Tish
reviewed
May 26, 2024
Inbal-Tish
reviewed
May 26, 2024
|
@adids1221 Can we remove all the deprecated props that are already commented out? |
adids1221
added
the
Important for Next Release
yes, I'll add another prop to the deprecation |
Inbal-Tish
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker children, migrate prop deprecation.
As part of the Picker refactor we are deprecating the
children, migrate, onShowprops and moving to use the items prop.Code cleanup from
migrate, children, getItemLabel, getItemValue, onShowwill be done in another PR.Changelog
Picker children, migrate prop deprecation.
Additional info
MADS-4178