Picker screens aligned to the new props migration #3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adids1221 Let's merge this PR first and then merge this one and then merge the deprecation warnings PR at the end. |
Inbal-Tish
approved these changes
May 26, 2024
|
@adids1221 There is another usage in the Picker tests. What about the WebDemo Picker example? |
About the test file, let's leave it for the test coverage effort I'm doing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker screens aligned to the new picker props deprecation.
Note: the only example didn't fixed yet is the
Custom Modalwhich has an issue with therenderItemfunction.I'm working on a fix separately.
Changelog
Picker screens refactor according to the Picker refactor.
Additional info
None