Infra/picker refactor #2 #1001
Merged
Infra/picker refactor #2 #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
the
Important for Next Release
Inbal-Tish
reviewed
Nov 16, 2020
Inbal-Tish
reviewed
Nov 16, 2020
Inbal-Tish
reviewed
Nov 16, 2020
Inbal-Tish
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(This PR depends on #1000)
Use context to pass Picker value to Picker Items.
This way we don't need to clone children and inject the props.
Also this support rendering children that are not picker items (like section separators)
Fixed issue with search functionality (broke after recent API migration)
Fixed issue with multi select mode with new API
Changelog
Refactor Picker component