Skip to content

Carousel - migrate to typescript #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 28, 2020
Merged

Carousel - migrate to typescript #1005

merged 10 commits into from
Oct 28, 2020

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

Carousel - migrate to typescript

Changelog

Carousel - migrate to typescript

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar October 26, 2020 15:34
@ethanshar ethanshar requested review from Inbal-Tish and removed request for ethanshar October 26, 2020 15:57
@ethanshar ethanshar assigned Inbal-Tish and unassigned ethanshar Oct 26, 2020
@Inbal-Tish
Copy link
Collaborator

@M-i-k-e-l You should remove the manual typings for the component as well.

@Inbal-Tish
Copy link
Collaborator

@M-i-k-e-l You need to remove export from src/index.ts file as well.

@M-i-k-e-l
Copy link
Collaborator Author

🤦
Fixed exports + changed screen to tsx + fixed statics

@Inbal-Tish Inbal-Tish merged commit feeacc7 into master Oct 28, 2020
@M-i-k-e-l M-i-k-e-l deleted the infra/typescript-carousel branch January 25, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inbal-Tish Inbal-Tish Inbal-Tish approved these changes

Assignees

@Inbal-Tish Inbal-Tish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M-i-k-e-l @Inbal-Tish @ethanshar