Fixes TouchableOpacity mandatory props error #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dor256
force-pushed
the
TS-touchable-opacity-fix
branch
from
97356f5 to
fcc9167
Compare
ethanshar
reviewed
Nov 5, 2020
Comment on lines
2
to
6
| import {TouchableOpacityProps as RNTouchableOpacityProps} from 'react-native'; | ||
| import {PureBaseComponent} from '../commons'; | ||
| import {AlignmentModifiers, FlexModifiers} from '../modifiers'; | ||
| import {AlignmentModifiers, FlexModifiers} from '../../src/commons/modifiers'; | ||
| import {ColorValue} from '../style/colors'; | ||
|
|
There was a problem hiding this comment.
If I not mistaken, I think this file should be removed..
not sure why we still have it
We're using the auto generated file
Maybe that's the reason we had issues with the component typings?
There was a problem hiding this comment.
Could be, let me check this locally before we remove it
Dor256
force-pushed
the
TS-touchable-opacity-fix
branch
from
83abfef to
1c114f7
Compare
|
I deleted the old typings file, I'm not entirely sure yet that it will fix the problem but let's try |
ethanshar
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TouchableOpacityhadRNTouchableOpacityprops mandatory, this PR makes it optionalChangelog
Fixes TS errors in
TouchableOpacity