-
Notifications
You must be signed in to change notification settings - Fork 734
Add fix for carousel asBaseComponent #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWSOME! 10x!
Could you please remove changes from CarouselScreen except the carousel = React.createRef<typeof Carousel>();
, and run npm run build:dev
?
Also, I've tried to see if it works in the private lib and I have a problem where the typings are working but the the actual ref. I hope that it will work once this is merged, we'll see.
Do you mean that the ref typing doesn't work or the ref in runtime doesn't work? Runtime shouldn't be affected by this change |
Runtime, I need to change the code to fix the TS errors and then the runtime does not work (although the code is the same as in the screen here, weird). |
Weird... The only change was to the typing, this shouldn't break any runtime code |
Did you run |
I did, but I got an error for |
Weird, I did and not did again and it removed the other files and I had no error with |
Only thing now is perhaps add an |
Up to you, it would be cleaner to add an interface like that to all components that have static members |
It seems that the usage is more cumbersome |
Description
Enter description to help the reviewer understand what's the change about...
Fix typing for carousel component
Changelog
Add a quick message for our users about this change
Fix typing issue with carousel component