Skip to content

feat/tracking view allow safeArea #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 3, 2020

Conversation

mendyEdri
Copy link
Contributor

Description

KeyboardTrackingView now allow users to disable the default safe-area space, default is true to avoid breaking changes

Changelog

KeyboardTrackingView now allow users to disable the default safe-area space by using useSafeArea={false}

@mendyEdri mendyEdri requested a review from M-i-k-e-l November 3, 2020 08:10
@mendyEdri mendyEdri changed the title Feat/tracking view allow safearea feat/tracking view allow safeArea Nov 3, 2020
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manage to see why the addBottomView is not working? Or is it something else?

@mendyEdri
Copy link
Contributor Author

Did you manage to see why the addBottomView is not working? Or is it something else?

@M-i-k-e-l
addBottomView is part of CustomKeyboardView and we are using here KeyboardTrackingView.
(the addBottomView is the view between the closed keyboard to the bottom of the screen)

@M-i-k-e-l M-i-k-e-l merged commit 96e6f1e into master Nov 3, 2020
@mendyEdri mendyEdri deleted the feat/tracking-view-allow-safearea branch November 8, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants