Skip to content

ChipsInput - Removing UNSAFE method #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2020
Merged

Conversation

Inbal-Tish
Copy link
Collaborator

Description

ChipsInput - Moving to 'asBaseComponent' HOC and removing UNSAFE method.

Changelog

ChipsInput - Removing UNSAFE method.

Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing this PR with master, the Chips looks a little different and the functionality for adding chips doesn't work.

@Inbal-Tish
Copy link
Collaborator Author

I'll re-check

@Inbal-Tish
Copy link
Collaborator Author

Fixed. Thanks!

@ethanshar ethanshar merged commit 0375ae5 into master Nov 13, 2020
@Inbal-Tish Inbal-Tish deleted the infra/ChipsInput_remove_UNSAFE branch November 16, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants