Props deprecations - CardImage, CardSection, StateScreen #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
added
the
Important for Next Release
M-i-k-e-l
reviewed
Nov 15, 2020
…precated props from demo screens; adding 'source' to StateScreen typings
M-i-k-e-l
reviewed
Nov 15, 2020
| LogService.warn( | ||
| 'uilib: Please stop passing borderRadius to Card.Image, it will get the borderRadius from the Card' | ||
| ); | ||
| LogService.deprecationWarn({component: 'CardImage', oldProp: 'borderRadius'}); |
There was a problem hiding this comment.
That's a good idea to add this option, but the current message expects the newProp (actually this is my bad, I need to fix LogService typings).
You can use the warn method for now.
There was a problem hiding this comment.
My suggestion is that we change the LogService deprecationWarn's massage to accommodate this scenario. What do you think?
There was a problem hiding this comment.
Added this option in the other PR
|
Looks like you need to run |
…a/add_deprecation_warnings
|
Done |
M-i-k-e-l
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting deprecation process for CardImage, CardSection, StateScreen with deprecation warning and support for old and new props.
Changelog
CardImage, CardSection, StateScreen - Adding props deprecation warnings.