-
Notifications
You must be signed in to change notification settings - Fork 734
Fix docs #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs #1024
Changes from all commits
923a9b4
b3f2398
fd790fe
f906870
9af59dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"presets": ["@babel/preset-typescript" /* , "@babel/preset-react" */], | ||
"plugins": ["babel-plugin-typescript-to-proptypes"], | ||
"plugins": [["babel-plugin-typescript-to-proptypes", {"comments": true}]], | ||
"compact": false, | ||
"minified": false | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
"author": "Kyle Mathews <[email protected]>", | ||
"dependencies": { | ||
"classnames": "^2.2.6", | ||
"gatsby": "2.23.22-static-query-template.8", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you test this on production? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems to work now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure it has been, locally I had There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe someone had deployed the docs from master and "broke" it :/ |
||
"gatsby": "^2.0.0", | ||
"gatsby-image": "^2.0.34", | ||
"gatsby-plugin-layout": "^1.3.10", | ||
"gatsby-plugin-manifest": "^2.0.24", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this deploy each time we build the docs (you removed that part from the notes)?
Also, is the CI calling
npm run docs:build
? Or should it be added to thebuild
phase?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see I scratch that in the PR description.
At first I called
docs:build
from thebuild
script.But it seems to not work and require more investigation.. so I dropped it for now.
docs:build
is not being used at the moment.. but that should be the script we will want to run in CI once we'll make it work.