add dateFormatter prop to dateTimePicker #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
requested review from
ethanshar
and removed request for
Inbal-Tish
Inbal-Tish
reviewed
Nov 11, 2020
| if (value) { | ||
| if (dateFormatter && mode === MODES.DATE) { |
There was a problem hiding this comment.
I would use a switch case here and include all logic in each case to make the code more readable. What do you think?
There was a problem hiding this comment.
I changed to switch case - not sure what is more readable..
Let me know if you have an idea for a better logic here :)
Inbal-Tish
reviewed
Nov 12, 2020
| if (dateFormatter) { | ||
| return dateFormatter(value); | ||
| } | ||
| return dateFormat ? moment(value).format(dateFormat) : value.toLocaleDateString(); |
There was a problem hiding this comment.
You can have all in one trinery:
return dateFormatter ? dateFormatter(value) : dateFormat ? moment(value).format(dateFormat) : value.toLocaleDateString();
Inbal-Tish
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add dateFormatter prop to dateTimePicker
Changelog
Add dateFormatter prop to dateTimePicker